feat: add foreign proposal validation #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
approved these changes
Jan 12, 2024
Merged
via the queue into
tari-project:development
with commit Jan 12, 2024
76bf409
11 checks passed
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
Description --- Move HS message receivers into worker, pass messages to the OnInboundMessage handler. This checks proposals for missing transactions and parks them if necessary. New transaction notifications are sent to the OnInboundMessage handler to check if any proposals can be unparked. Once unparked, they are added to the "next message buffer". The message buffer is polled (cancel safe) in the consensus worker tokio select loop. Motivation and Context --- Clean up after fix in #889 How Has This Been Tested? --- Running stress test from PR #880 What process can a PR reviewer use to test or verify this change? --- Consensus should still work as before Breaking Changes --- - [x] None - [ ] Requires data directory to be deleted - [ ] Other - Please specify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do most of the validation for foreign proposals as their are done on the local proposals.
I had to move the tokio::select from on_inbound_message to the parent tokio select, so it will stop being cancelled. I tried to fuse it instead but then I got into mutability concurrency issue.
Motivation and Context
Fixes #887
How Has This Been Tested?
Running dan-testing and looking at the logs. The
requester abandoned requestis gone.What process can a PR reviewer use to test or verify this change?
Same as above.
Breaking Changes