fix(consensus)!: allow multiple read-only shard references in proposals #894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes locks in evidence
Checks locks when proposing to allow multiple input refs
Motivation and Context
Evidence for each shard within a TransactionAtom now includes the lock type.
Updated the proposal db query to check each lock type and ensure that conflicts either don't occur or if they do they are all read locks.
How Has This Been Tested?
Ran a stress test from #880, previously after #885 was merged, funding the tariswap components would take a very long time (I've never actually run it to completion, but ran for 30 mins without completing). With this PR funding took roughly a minute on my test. Swap batches are also reaching finalization within an acceptable timeframe.
What process can a PR reviewer use to test or verify this change?
Submit multiple transactions which use a single substate as an input ref and check that they can be added to the same block.
Breaking Changes