fix(consensus): improve block fullness when tx rate is high #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Jan 25, 2024
Merged
via the queue into
tari-project:development
with commit Jan 25, 2024
dc84898
13 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Jan 26, 2024
* development: fix(consensus): improve block fullness when tx rate is high (tari-project#916)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove calls to
beatwhen receiving a local proposalOnly call
beaton new transactions when there no transactions pending executionReduced some info log noisiness
Motivation and Context
beatwas called when receiving a local proposal, however this is not necessary unless you are the leader.beatis called when receiving votes (including from self) as the next leader so this PR essentially only calls beat on reciept of a proposal if it is the next leader.If there is only a single transaction, we avoid waiting for the block time by allowing the mempool to send how many transactions are awaiting execution allowing consensus to process the single transaction immediately, or wait for multiple transactions to finish executing before proposing.
How Has This Been Tested?
Manually, stess test and single transactions.
250 stress test with 2 shards:
What process can a PR reviewer use to test or verify this change?
Stress test and check how many commands are proposed in a block
Breaking Changes