Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt validator node to ts-rs exported interfaces #923

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Jan 30, 2024

Description

This PR removes all the any that could be replaced by our auto-generated interfaces/types.
Now the jsonrpc calls is expecting the proper request and gives proper response. So when the structure changes we will know.

Motivation and Context

How Has This Been Tested?

Running dan-testing with a wallet with some accounts and transactions.

What process can a PR reviewer use to test or verify this change?

Same as above, maybe there is something I haven't tested (looked at). But at the first glance it's working as expected.

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Feb 7, 2024

Test Results (CI)

487 tests  +12   487 ✅ +12   1h 43m 59s ⏱️ - 1m 0s
 59 suites ± 0     0 💤 ± 0 
  2 files   ± 0     0 ❌ ± 0 

Results for commit 62081ca. ± Comparison against base commit 83c6491.

This pull request removes 3 and adds 15 tests. Note that renamed tests count towards both.
tari_validator_node_client ‑ types::export_bindings_getshardkey
tari_validator_node_client ‑ types::export_bindings_getvalidatorfeesrequest
tari_validator_node_client ‑ types::export_bindings_getvalidatorfeesresponse
tari_dan_common_types ‑ committee::export_bindings_committee
tari_dan_common_types ‑ peer_address::export_bindings_peeraddress
tari_dan_common_types ‑ shard::export_bindings_shard
tari_dan_storage ‑ consensus_models::transaction_pool::export_bindings_transactionpoolrecord
tari_dan_storage ‑ consensus_models::transaction_pool::export_bindings_transactionpoolstage
tari_validator_node_client ‑ types::export_bindings_getallvnsrequest
tari_validator_node_client ‑ types::export_bindings_getallvnsresponse
tari_validator_node_client ‑ types::export_bindings_getcommitteeresponse
tari_validator_node_client ‑ types::export_bindings_getcommsstatsresponse
tari_validator_node_client ‑ types::export_bindings_getmempoolstatsresponse
…

♻️ This comment has been updated with latest results.

@Cifko Cifko force-pushed the ts-rs-validator-node branch from f2bf2c8 to 31fcf8d Compare February 14, 2024 10:54
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sdbondi sdbondi added this pull request to the merge queue Feb 15, 2024
Merged via the queue into tari-project:development with commit f4df35e Feb 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants