fix(engine)!: determinism bug with log entries #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
engine-fix-determinism-bug-tx-receipt
branch
from
4a20fd6 to
3a7ea47
Compare
Cifko
previously approved these changes
Feb 1, 2024
Cifko
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove timestamp from LogEntry to fix determinism bug in txreceipt
Removed timestamp from UI
Motivation and Context
Initially logs were not part of any substate, but these are added in TxReceipt. Logs contained a timestamp based on the local clock of the VN.
This PR removes the timestamp, ordering is maintained by the Vec.
How Has This Been Tested?
Not explicitly tested. This caused Merkle root mismatches in #924
What process can a PR reviewer use to test or verify this change?
Check that tx receipt does not have local time in it
Breaking Changes