Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure libp2p fork is used in crates.io #928

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Feb 7, 2024

Description

Specify libp2p fork as a dependency rather than a patch
Use workspace deps for libp2p_peersync behaviour

Motivation and Context

When building from outside the repo, patches are not used. For now, it's just easier to specify the git fork as a direct dependency rather than patching crates.io.

ALso looks like the zeroize issue for liblmdb-sys is resolved, so the patch is removed

How Has This Been Tested?

Lints/CI

What process can a PR reviewer use to test or verify this change?

CI

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Feb 7, 2024

Test Results (CI)

79 tests   - 357   78 ✅  - 358   59m 32s ⏱️ - 48m 39s
16 suites  -  41    0 💤 ±  0 
 1 files    -   1    1 ❌ +  1 

For more details on these failures, see this check.

Results for commit fb9e6ec. ± Comparison against base commit 704fef0.

This pull request removes 357 tests.
Scenario: Claim and transfer confidential assets via wallet daemon: tests/features/wallet_daemon.feature:89:5
Scenario: Claim base layer burn funds with wallet daemon: tests/features/claim_burn.feature:6:3
Scenario: Claim validator fees: tests/features/claim_fees.feature:6:3
Scenario: Confidential transfer to unexisting account: tests/features/transfer.feature:163:3
Scenario: Counter template registration and invocation: tests/features/counter.feature:7:3
Scenario: Create account and transfer faucets via wallet daemon: tests/features/wallet_daemon.feature:7:5
Scenario: Create and mint account NFT: tests/features/wallet_daemon.feature:133:5
Scenario: Create resource and mint in one transaction: tests/features/nft.feature:73:3
Scenario: Double Claim base layer burn funds with wallet daemon. should fail: tests/features/claim_burn.feature:44:3
Scenario: Indexer GraphQL requests events over network substate indexing: tests/features/indexer.feature:118:3
…

♻️ This comment has been updated with latest results.

@stringhandler stringhandler added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@sdbondi sdbondi added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@sdbondi sdbondi added this pull request to the merge queue Feb 9, 2024
Merged via the queue into tari-project:development with commit 91cbb71 Feb 9, 2024
10 of 11 checks passed
@sdbondi sdbondi deleted the remove-patches branch February 9, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants