feat: add p2pool tip info and better mmproxy template handling (#6795)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new RPC method to retrieve tip information from the
P2Pool service.
	- Added a new variable for user agent configuration in the HTTP client.
- **Refactor**
- Streamlined block template management with a new management structure.
- Simplified method signatures and reduced parameter complexity in
several service methods.
- **Bug Fixes**
- Improved error handling in the retrieval of node and network state
metrics.
- **Chores**
	- Updated project dependencies and made minor formatting adjustments.
	- Renamed modules for better clarity and organization.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

.github/workflows/ci.yml

@@ -115,7 +115,7 @@ jobs:
             tari-${{ runner.os }}-${{ runner.cpu-model }}-${{ env.toolchain }}-nightly
       - name: cargo machete
         run: |
-          cargo install cargo-machete
+          cargo install cargo-machete@0.7.0
           cargo machete
 
   build-stable:

applications/minotari_app_grpc/proto/p2pool.proto

@@ -27,10 +27,23 @@ import "base_node.proto";
 import "block.proto";
 
 service ShaP2Pool {
+  rpc GetTipInfo(GetTipInfoRequest) returns(GetTipInfoResponse);
   rpc GetNewBlock(GetNewBlockRequest) returns(GetNewBlockResponse);
   rpc SubmitBlock(SubmitBlockRequest) returns(tari.rpc.SubmitBlockResponse);
 }
 
+message GetTipInfoRequest {
+}
+
+message GetTipInfoResponse {
+  uint64 node_height = 1;
+  bytes node_tip_hash = 2;
+  uint64 p2pool_rx_height = 3;
+  bytes p2pool_rx_tip_hash = 4;
+  uint64 p2pool_sha_height = 5;
+  bytes p2pool_sha_tip_hash = 6;
+}
+
 message GetNewBlockRequest {
   tari.rpc.PowAlgo pow = 1;
   string coinbase_extra = 2;

applications/minotari_merge_mining_proxy/Cargo.toml

@@ -40,7 +40,7 @@ hyper = { version = "0.14.12", features = ["default"] }
 jsonrpc = "0.12.0"
 log = { version = "0.4.8", features = ["std"] }
 markup5ever = "0.12.1"
-monero = { version = "0.21.0" , features = ["serde"] }
+monero = { version = "0.21.0", features = ["serde"] }
 reqwest = { version = "0.11.4", features = ["json"] }
 serde = { version = "1.0.136", features = ["derive"] }
 serde_json = "1.0.57"
@@ -53,6 +53,7 @@ scraper = "0.19.0"
 toml = "0.8.19"
 rand = "0.8"
 regex = "1.11.1"
+blake2 = "0.10"
 
 [build-dependencies]
 tari_features = { path = "../../common/tari_features", version = "1.11.5-pre.0" }

applications/minotari_merge_mining_proxy/src/block_template_data.rs

@@ -22,7 +22,7 @@
 
 //! Provides methods for building template data and storing them with timestamps.
 
-use std::{collections::HashMap, convert::TryFrom, sync::Arc};
+use std::{collections::HashMap, sync::Arc};
 
 #[cfg(not(test))]
 use chrono::Duration;
@@ -33,47 +33,19 @@ use tari_core::{proof_of_work::monero_rx::FixedByteArray, AuxChainHashes};
 use tokio::sync::RwLock;
 use tracing::trace;
 
-use crate::{
-    block_template_protocol::{FinalBlockTemplateData, NewBlockTemplateData},
-    error::MmProxyError,
-};
+use crate::{block_template_manager::FinalBlockTemplateData, error::MmProxyError};
 
 const LOG_TARGET: &str = "minotari_mm_proxy::xmrig";
 
 /// Structure for holding hashmap of hashes -> [BlockRepositoryItem] and [TemplateRepositoryItem].
 #[derive(Debug, Clone)]
-pub struct BlockTemplateRepository {
+pub(crate) struct BlockTemplateRepository {
     blocks: Arc<RwLock<HashMap<Vec<u8>, BlockRepositoryItem>>>,
-    templates: Arc<RwLock<HashMap<Vec<u8>, TemplateRepositoryItem>>>,
-}
-
-/// Structure holding [NewBlockTemplate] along with a timestamp.
-#[derive(Debug, Clone)]
-pub struct TemplateRepositoryItem {
-    pub new_block_template: NewBlockTemplateData,
-    pub template_with_coinbase: grpc::NewBlockTemplate,
-    datetime: DateTime<Utc>,
-}
-
-impl TemplateRepositoryItem {
-    /// Create new [Self] with current time in UTC.
-    pub fn new(new_block_template: NewBlockTemplateData, template_with_coinbase: grpc::NewBlockTemplate) -> Self {
-        Self {
-            new_block_template,
-            template_with_coinbase,
-            datetime: Utc::now(),
-        }
-    }
-
-    /// Get the timestamp of creation.
-    pub fn datetime(&self) -> DateTime<Utc> {
-        self.datetime
-    }
 }
 
 /// Structure holding [FinalBlockTemplateData] along with a timestamp.
 #[derive(Debug, Clone)]
-pub struct BlockRepositoryItem {
+pub(crate) struct BlockRepositoryItem {
     pub data: FinalBlockTemplateData,
     datetime: DateTime<Utc>,
 }
@@ -97,7 +69,6 @@ impl BlockTemplateRepository {
     pub fn new() -> Self {
         Self {
             blocks: Arc::new(RwLock::new(HashMap::new())),
-            templates: Arc::new(RwLock::new(HashMap::new())),
         }
     }
 
@@ -107,60 +78,12 @@ impl BlockTemplateRepository {
         b.get(merge_mining_hash.as_ref()).map(|item| item.data.clone())
     }
 
-    /// Return [BlockTemplateData] with the associated hash. None if the hash is not stored.
-    pub async fn get_new_template<T: AsRef<[u8]>>(
-        &self,
-        best_block_hash: T,
-    ) -> Option<(NewBlockTemplateData, grpc::NewBlockTemplate)> {
-        let b = self.templates.read().await;
-        b.get(best_block_hash.as_ref())
-            .map(|item| (item.new_block_template.clone(), item.template_with_coinbase.clone()))
-    }
-
     /// Store [FinalBlockTemplateData] at the hash value if the key does not exist.
-    pub async fn save_final_block_template_if_key_unique(
-        &self,
-        merge_mining_hash: Vec<u8>,
-        block_template: FinalBlockTemplateData,
-    ) {
+    pub async fn save_final_block_template_if_key_unique(&self, block_template: FinalBlockTemplateData) {
+        let merge_mining_hash = block_template.aux_chain_mr.to_vec();
         let mut b = self.blocks.write().await;
-        b.entry(merge_mining_hash.clone()).or_insert_with(|| {
-            trace!(
-                target: LOG_TARGET,
-                "Saving final block template with merge mining hash: {:?}",
-                hex::encode(&merge_mining_hash)
-            );
-            BlockRepositoryItem::new(block_template)
-        });
-    }
-
-    /// Store [NewBlockTemplate] at the hash value if the key does not exist.
-    pub async fn save_new_block_template_if_key_unique(
-        &self,
-        best_block_hash: Vec<u8>,
-        new_block_template: NewBlockTemplateData,
-        template_with_coinbase: grpc::NewBlockTemplate,
-    ) {
-        let mut b = self.templates.write().await;
-        b.entry(best_block_hash.clone()).or_insert_with(|| {
-            trace!(
-                target: LOG_TARGET,
-                "Saving new block template for best block hash: {:?}",
-                hex::encode(&best_block_hash)
-            );
-            TemplateRepositoryItem::new(new_block_template, template_with_coinbase)
-        });
-    }
-
-    /// Check if the repository contains a block template with best_previous_block_hash
-    pub async fn blocks_contains(&self, current_best_block_hash: FixedHash) -> Option<FinalBlockTemplateData> {
-        let b = self.blocks.read().await;
-        b.values()
-            .find(|item| {
-                let header = item.data.template.tari_block.header.clone().unwrap_or_default();
-                FixedHash::try_from(header.prev_hash).unwrap_or(FixedHash::default()) == current_best_block_hash
-            })
-            .map(|val| val.data.clone())
+        b.entry(merge_mining_hash)
+            .or_insert_with(|| BlockRepositoryItem::new(block_template));
     }
 
     /// Remove any data that is older than 20 minutes.
@@ -172,13 +95,6 @@ impl BlockTemplateRepository {
         #[cfg(not(test))]
         let threshold = Utc::now() - Duration::minutes(20);
         *b = b.drain().filter(|(_, i)| i.datetime() >= threshold).collect();
-        trace!(target: LOG_TARGET, "Removing outdated new block templates");
-        let mut b = self.templates.write().await;
-        #[cfg(test)]
-        let threshold = Utc::now();
-        #[cfg(not(test))]
-        let threshold = Utc::now() - Duration::minutes(20);
-        *b = b.drain().filter(|(_, i)| i.datetime() >= threshold).collect();
     }
 
     /// Remove a particularfinla block template for hash and return the associated [BlockRepositoryItem] if any.
@@ -191,22 +107,11 @@ impl BlockTemplateRepository {
         let mut b = self.blocks.write().await;
         b.remove(hash.as_ref())
     }
-
-    /// Remove a particular new block template for hash and return the associated [BlockRepositoryItem] if any.
-    pub async fn remove_new_block_template<T: AsRef<[u8]>>(&self, hash: T) -> Option<TemplateRepositoryItem> {
-        trace!(
-            target: LOG_TARGET,
-            "New block template removed with best block hash {:?}",
-            hex::encode(hash.as_ref())
-        );
-        let mut b = self.templates.write().await;
-        b.remove(hash.as_ref())
-    }
 }
 
 /// Setup values for the new block.
 #[derive(Clone, Debug)]
-pub struct BlockTemplateData {
+pub(crate) struct BlockTemplateData {
     pub monero_seed: FixedByteArray,
     pub tari_block: grpc::Block,
     pub tari_miner_data: grpc::MinerData,
@@ -221,7 +126,7 @@ impl BlockTemplateData {}
 
 /// Builder for the [BlockTemplateData]. All fields have to be set to succeed.
 #[derive(Default)]
-pub struct BlockTemplateDataBuilder {
+pub(crate) struct BlockTemplateDataBuilder {
     monero_seed: Option<FixedByteArray>,
     tari_block: Option<grpc::Block>,
     tari_miner_data: Option<grpc::MinerData>,
@@ -312,8 +217,8 @@ impl BlockTemplateDataBuilder {
 }
 
 #[cfg(test)]
-pub mod test {
-    use std::convert::TryInto;
+mod test {
+    use std::convert::{TryFrom, TryInto};
 
     use tari_core::{
         blocks::{Block, BlockHeader},
@@ -323,7 +228,7 @@ pub mod test {
     use tari_utilities::ByteArray;
 
     use super::*;
-    use crate::block_template_protocol::AuxChainMr;
+    use crate::block_template_manager::AuxChainMr;
 
     fn create_block_template_data() -> FinalBlockTemplateData {
         let header = BlockHeader::new(100);
@@ -358,25 +263,17 @@ pub mod test {
     #[tokio::test]
     async fn test_block_template_repository() {
         let btr = BlockTemplateRepository::new();
-        let hash1 = vec![1; 32];
-        let hash2 = vec![2; 32];
-        let hash3 = vec![3; 32];
         let block_template = create_block_template_data();
-        btr.save_final_block_template_if_key_unique(hash1.clone(), block_template.clone())
-            .await;
-        btr.save_final_block_template_if_key_unique(hash2.clone(), block_template)
+        let hash1 = block_template.aux_chain_mr.to_vec();
+        btr.save_final_block_template_if_key_unique(block_template.clone())
             .await;
         assert!(btr.get_final_template(hash1.clone()).await.is_some());
-        assert!(btr.get_final_template(hash2.clone()).await.is_some());
-        assert!(btr.get_final_template(hash3.clone()).await.is_none());
         assert!(btr.remove_final_block_template(hash1.clone()).await.is_some());
         assert!(btr.get_final_template(hash1.clone()).await.is_none());
-        assert!(btr.get_final_template(hash2.clone()).await.is_some());
-        assert!(btr.get_final_template(hash3.clone()).await.is_none());
+        btr.save_final_block_template_if_key_unique(block_template).await;
+        assert!(btr.get_final_template(hash1.clone()).await.is_some());
         btr.remove_outdated().await;
         assert!(btr.get_final_template(hash1).await.is_none());
-        assert!(btr.get_final_template(hash2).await.is_none());
-        assert!(btr.get_final_template(hash3).await.is_none());
     }
 
     #[test]