feat: verify wallet recovery #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Verified wallet recovery does not always start scanning from the genesis block instead of from a bit before the closest wallet birthday block. - Fixed a Windows build error introduced by tari-project#6783.
Test Results (CI) 3 files 129 suites 34m 57s ⏱️ Results for commit 431b47a. |
Test Results (Integration tests) 2 files 11 suites 30m 5s ⏱️ For more details on these failures, see this check. Results for commit 431b47a. |
SWvheerden
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
See #6787
How Has This Been Tested?
New unit test
System-level testing (wallet recovery)
What process can a PR reviewer use to test or verify this change?
Code review
Breaking Changes