Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump outdated dependencies #1562

Merged
merged 4 commits into from
Feb 25, 2025
Merged

chore: bump outdated dependencies #1562

merged 4 commits into from
Feb 25, 2025

Conversation

shanimal08
Copy link
Collaborator

@shanimal08 shanimal08 commented Feb 25, 2025

Description

  • bumped FE dependencies not on wanted version
  • update CI: use specific cargo-machete version (0.7.0)

How has this been tested?

  • locally:
    • ran through app and
    • checked changelogs for breaking changes (none)

Summary by CodeRabbit

  • Chores
    • Refined CI configuration by standardizing environment settings and specifying tool versions.
    • Upgraded several core dependencies and development tools to newer versions for improved reliability and performance.

@shanimal08 shanimal08 marked this pull request as ready for review February 25, 2025 10:21
@shanimal08 shanimal08 requested a review from a team as a code owner February 25, 2025 10:21
Copy link

coderabbitai bot commented Feb 25, 2025

📝 Walkthrough

Walkthrough

This update modifies the CI workflow configuration and the project dependencies. In the CI file, an extra space in the TELEMETRY_API_URL variable was removed, and the cargo install command now includes a specific version. Additionally, multiple dependency and development dependency versions in the package.json file were updated. No changes were made to public or exported interfaces.

Changes

File Summary
.github/.../ci.yml Removed trailing space from TELEMETRY_API_URL; updated cargo install command to include version.
package.json Updated versions for various dependencies and development dependencies.

Sequence Diagram(s)

sequenceDiagram
    participant CI as CI Workflow
    participant Env as Environment Setup
    participant Cargo as Cargo Install Step

    CI->>Env: Set TELEMETRY_API_URL (trim trailing space)
    CI->>Cargo: Run "cargo install --version 0.7.0 cargo-machete"
Loading

Poem

I'm a rabbit with code so neat,
Hopping through changes with quick little feet,
I removed a space and set a version clear,
Dependencies updated, oh what cheer!
In lines of code, my joy is here!
🐇💻✨


📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9d147f and 3df2717.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • .github/workflows/ci.yml (2 hunks)
  • package.json (2 hunks)
✅ Files skipped from review due to trivial changes (2)
  • .github/workflows/ci.yml
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: tauri-build

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@leet4tari
Copy link
Contributor

I don't think we need the package*.json files in the PR, just the CI workflow?

@shanimal08
Copy link
Collaborator Author

I don't think we need the package*.json files in the PR, just the CI workflow?

oh i opened this PR specifically to bump the outdated FE deps, which is what those changes are - then noticed the CI failures. i can split into two separate PRs if need be though?

@brianp brianp merged commit da276c5 into tari-project:main Feb 25, 2025
9 checks passed
@leet4tari
Copy link
Contributor

I did not see the explanation for both, as long as they both noted, I think it good to go.

@shanimal08 shanimal08 deleted the bump branch February 25, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants