Skip to content

Comments

chore: Fix syntax checking to include run-task file#279

Closed
hneiva wants to merge 4 commits intomainfrom
hneiva/syntax-check-fix
Closed

chore: Fix syntax checking to include run-task file#279
hneiva wants to merge 4 commits intomainfrom
hneiva/syntax-check-fix

Conversation

@hneiva
Copy link
Contributor

@hneiva hneiva commented Jun 23, 2023

No description provided.

@hneiva hneiva requested a review from ahal June 23, 2023 17:53
@hneiva
Copy link
Contributor Author

hneiva commented Jun 23, 2023

Here is another example of the GH integration behaving different from local commit hooks.
When I committed my changes it didn't complain about fetch-content file 😵‍💫

pyproject.toml Outdated
target-version = "py37"
exclude = [
"src/taskgraph/run-task/robustcheckout.py",
"taskcluster/scripts/external_tools/tooltool.py",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just exclude all of external_tools as presumably we wouldn't want to lint anything in there.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

❌ Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.65%. Comparing base (dc1b8ea) to head (9d1f159).
⚠️ Report is 545 commits behind head on main.

Files with missing lines Patch % Lines
src/taskgraph/run-task/fetch-content 0.00% 13 Missing ⚠️
src/taskgraph/run-task/run-task 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files          69       69           
  Lines        6301     6301           
  Branches     1269     1269           
=======================================
  Hits         3696     3696           
  Misses       2328     2328           
  Partials      277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hneiva hneiva force-pushed the hneiva/syntax-check-fix branch from d5d0186 to 9d1f159 Compare June 23, 2023 19:10
@ahal
Copy link
Collaborator

ahal commented Oct 7, 2025

I recently fixed this elsewhere

@ahal ahal closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants