-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1449 , but has dependency on mkdocs 1.6 #1460
Conversation
the script command sections consist of only 2 characters (i.e. >D), hence with default setting they will not be reported as hits. See https://www.mkdocs.org/user-guide/configuration/#min_search_length
it seems mkdocs needs to be upgraded to 1.6 for this setting to work. https://github.com/tasmota/docs/blob/master/requirements.txt currently specifies 1.5.3 Who could test the update as a prerequisite to my PR? |
upgrading is described in https://www.mkdocs.org/about/release-notes/ |
I did some quick local tests and did not encounter problems with the newest version. |
It must be another problem as mkdocs 1.6.1 was already used anyway according to the GH action log:
Did you check successfully with a local installation? |
No, I'm only used to update docs in projects that use GH Actions to validate all changes. |
could the issue be caused by mkdocs-material and its search component Lunr.js?
|
Yes, could be.
You see that the search plugin from mkdocs-material is referred here, which does not seem to have the option Maybe someone with more knowledge about MkDocs can enlighten us. |
well my goal is NOT to understand all internals of mkdocs, it just appeared to be an easy fix to an annoying issue in doc search. |
@Staars @arendst maybe switching to theme "Read the Docs" would resolve the severe issues mention by theme "material" developers |
the script command sections consist of only 2 characters (i.e. >D), hence with default search setting they will not be reported as hits. See https://www.mkdocs.org/user-guide/configuration/#min_search_length