fix: update payment validation and streamline payment profile retrieval

Signed-off-by: Sam Poyigi <[email protected]>
tastyigniter · Sep 22, 2024 · 4ba4459 · 4ba4459
1 parent 916a3aa
commit 4ba4459
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/resources/js/process.square.js b/resources/js/process.square.js
@@ -12,7 +12,6 @@
     }
 
     ProcessSquare.prototype.init = function () {
-        console.log(this.$checkoutForm.checkout('selectedPaymentInput').val())
         if (this.$checkoutForm.checkout('selectedPaymentInput').val() !== 'square') return
 
         if (!$(this.options.cardSelector).length || $(this.options.cardSelector+' iframe').length)

diff --git a/resources/js/process.stripe.js b/resources/js/process.stripe.js
@@ -33,7 +33,7 @@
         this.$checkoutForm
             .on('submitCheckoutForm', $.proxy(this.submitFormHandler, this))
             .on('submit', function () {
-                if (self.$checkoutForm.find('input[name="form.payment"]:checked').val() !== 'stripe')
+                if (self.$checkoutForm.find('input[name="fields.payment"]:checked').val() !== 'stripe')
                     return
 
                 self.paymentElement?.update({disabled: true});

diff --git a/resources/views/_partials/stripe/payment_form.blade.php b/resources/views/_partials/stripe/payment_form.blade.php
@@ -1,4 +1,7 @@
-@php($paymentProfile = $paymentMethod->paymentProfileExists($order->customer) ? $paymentMethod->findPaymentProfile($order->customer) : null)
+@php($paymentProfile = $order->customer && $paymentMethod->paymentProfileExists($order->customer)
+    ? $paymentMethod->findPaymentProfile($order->customer)
+    : null
+)
 <div
     id="stripePaymentForm"
     class="payment-form ms-2 mt-3"

diff --git a/src/Http/Controllers/Payments.php b/src/Http/Controllers/Payments.php
@@ -75,7 +75,7 @@ public function index()
     public function index_onSetDefault($context = null)
     {
         $data = $this->validate(post(), [
-            'default' => 'required|integer|exists:'.Payment::class.',payment_id',
+            'default' => 'required|alpha_dash|exists:'.Payment::class.',code',
         ]);
 
         if (Payment::updateDefault($data['default'])) {