Skip to content

Comments

update starlight and astro ecosystem pkgs#3196

Merged
vasfvitor merged 40 commits intov2from
update-starlight-astro
Jul 10, 2025
Merged

update starlight and astro ecosystem pkgs#3196
vasfvitor merged 40 commits intov2from
update-starlight-astro

Conversation

@vasfvitor
Copy link
Contributor

@vasfvitor vasfvitor commented Mar 5, 2025

see latest comment


old:

was doing it on renovate pr but I guess it would be best if we had some eyes in it before merging

  • check if starlight pnpm patch is working fine
  • fix src\content\config.ts
  • fix toc
  • fix overrides
  • fix Astro.props usage
  • fix
  • fix some more

https://docs.astro.build/en/guides/upgrade-to/v5/
https://github.com/tauri-apps/tauri-docs/pull/2519/files

image

what I tried:

  • removing sidebar entry at astro config - doesn't work
  • removing blog-plugin - fixes it
  • empty sidebar entry - doesn't work
  • changing plugins order - doesn't work

what can be tried:

  • checking where the issue comes from, is it from starlight-utils or starlight-blog?

starlight-utils/middleware.ts:65:15

Blog cannot be used with multi-sidebar.

Each top-level sidebar item in the Starlight config must be either a group or autogenerated.

See https://starlight.astro.build/guides/sidebar/#groups and https://starlight.astro.build/guides/sidebar/#autogenerated-groups for more details.

edit 30-05

it seems that starlightBlog({ authors, navigation: 'none' }), setting the navigation option to 'none' fixed the current issue. It appears to be that the plugin was trying to override ThemeSelect/Header to place /blog and the error did not reflected the actual issue.

but now the error happens when navigating to /blog:

All posts cannot be used with multi-sidebar.
 
   Each top-level sidebar item in the Starlight config must be either a group or autogenerated.
 
   See https://starlight.astro.build/guides/sidebar/#groups and https://starlight.astro.build/guides/sidebar/#autogenerated-groups for more details.

image

@netlify
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for tauri-v2 ready!

Name Link
🔨 Latest commit 9ce09f3
🔍 Latest deploy log https://app.netlify.com/projects/tauri-v2/deploys/686ff3d555056a0008e1a7ad
😎 Deploy Preview https://deploy-preview-3196--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@vasfvitor vasfvitor force-pushed the update-starlight-astro branch from 080f54e to d5c3954 Compare May 1, 2025 19:16
@socket-security
Copy link

socket-security bot commented May 2, 2025

@vasfvitor vasfvitor force-pushed the update-starlight-astro branch 2 times, most recently from b80dcf7 to 20c96e3 Compare May 2, 2025 03:25
@vasfvitor vasfvitor added the bug Does it fix inaccurate content or fix a bug? label May 2, 2025
@github-actions github-actions bot added i18n Is this related to translations? i18n: zh-cn Is this related to zh-cn translations? i18n: fr It this related to fr translations? i18n: ja Is this related to it translations? labels Jul 3, 2025
@vasfvitor
Copy link
Contributor Author

vasfvitor commented Jul 3, 2025

TODO:

  • fix light mode
  • [ ]

@vasfvitor vasfvitor added enhancement Does it add or improve content? dependencies Does it update a dependency? labels Jul 4, 2025
Comment on lines +18 to +19
"matchPackageNames": ["typedoc", "typedoc-plugin-markdown", "typedoc-plugin-mdn-links"],
"enabled": false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating these broke the js-api-generator, probably still builds because of caching of older versions

Comment on lines +6 to +13
--sl-hue-orange: 35;
--sl-color-orange-low: hsl(var(--sl-hue-orange), 100%, 15%);
--sl-color-orange: hsl(var(--sl-hue-orange), 100%, 60%);
--sl-color-orange: #ffc131;
--sl-color-orange-high: hsl(var(--sl-hue-orange), 100%, 90%);
--sl-hue-blue: 186;
--sl-color-blue-low: hsl(var(--sl-hue-blue), 72%, 15%);
--sl-color-blue: hsl(var(--sl-hue-blue), 72%, 50%);
--sl-color-blue-high: hsl(var(--sl-hue-blue), 72%, 90%);
--sl-hue-blue: 187;
--sl-color-blue-low: hsl(var(--sl-hue-blue), 71%, 15%);
--sl-color-blue: #24c8db;
--sl-color-blue-high: hsl(var(--sl-hue-blue), 71%, 90%);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only dark mode has a Tauri styled theme

@vasfvitor vasfvitor marked this pull request as ready for review July 5, 2025 22:27
@vasfvitor vasfvitor requested a review from a team as a code owner July 5, 2025 22:27
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vasfvitor 🫡

@vasfvitor vasfvitor merged commit 89bf4cb into v2 Jul 10, 2025
9 checks passed
@vasfvitor vasfvitor deleted the update-starlight-astro branch July 10, 2025 17:19
@github-project-automation github-project-automation bot moved this from 🪵 Backlog to ✅ Done in Documentation Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Does it fix inaccurate content or fix a bug? dependencies Does it update a dependency? enhancement Does it add or improve content? i18n: fr It this related to fr translations? i18n: ja Is this related to it translations? i18n: zh-cn Is this related to zh-cn translations? i18n Is this related to translations?

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants