-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markup: New & better graphics, remove spec css element #3352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that print-front-cover.svg
has the edition number and 2024 hard-coded. Is the plan that this needs to be manually updated every year? Is there a script to generate this?
It's an SVG, it should be very easy to do this: |
Alright cover will be automatically generated in the future, files live with ecmarkup. |
Should be ready, sorry for the delay @gesa. Unfortunately we don't have a copy of Prince so once this lands we'll need your help to confirm we didn't mess it up somehow. |
@bakkot there were some issues with ecmarkup v21, but here’s the ecma262 PDF pulled from main and built with ecmarkup a004373. |
@gesa Nice, thanks. I'll review in more detail later, but on a quick glance, noticed:
|
@bakkot Annex headers are supposed to be centered, that’s one of the fixes in tc39/ecmarkup#638 I’ll take a look at the rest! |
Do not merge until tc39/ecmarkup#600 is merged & updated.