Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature list #101

Merged
merged 4 commits into from
Mar 4, 2019
Merged

new feature list #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a923c80
new feature list
codehag Feb 28, 2019
2fc79dc
address issues about feature list
codehag Mar 4, 2019
e234710
align submenu with menu
codehag Mar 4, 2019
5882283
change show example styling
codehag Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions _data/stage3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
});
});
}
resources:
- https://github.com/tc39/proposal-dynamic-import

- title: Legacy RegExp features in JavaScript
description: This is a specification draft for the legacy (deprecated) RegExp features in JavaScript, i.e., static properties of the constructor like RegExp.$1 as well as the RegExp.prototype.compile method.
Expand Down
4 changes: 2 additions & 2 deletions _includes/intro.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<section class="intro">
<div class="g-row">
<section >
<div class="g-row intro">
<div class="g-col-4">
<h2 class="section-headline">TC39</h2>
<p>
Expand Down
111 changes: 57 additions & 54 deletions _includes/proposals.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,70 +9,73 @@ <h3>Stage 3</h3>
</i>
{% for proposal in site.data.stage3 %}
<section class="featurelist__item">
<header class="featurelist__item__intro" tabindex="0">
<h4>{{ proposal.title }}</h4>
{% if proposal.description %}
<p>{{ proposal.description }}</p>
{% endif %}
</header>
<section class="featurelist__item__info" aria-hidden="true" tabindex="-1">
<div>
<div>
<h5>Status</h5>
<ul class="featurelist__item__status">
<li class="featurelist__item__owner">
<p>Author(s)</p>
{% if proposal.authors | size %}
<p>{{ proposal.authors | join: ", " }}</p>
{% else %}
<p>–</p>
{% endif %}
</li>
<li class="featurelist__item__owner">
<p>Champion(s)</p>
{% if proposal.champions | size %}
<p>{{ proposal.champions | join: ", " }}</p>
{% else %}
<p>–</p>
<section class="">
<header class="featurelist__item__intro" tabindex="0">
{% for url in proposal.resources %}
<section class="g-row">
<h4 class="featurelist__item__title flex-grow">
<a href="{{ url }}">{{ proposal.title }}</a>
</h4>
{% endfor %}
<section class="featurelist__item__tags flex-shrink" tabindex="-1">
<ul class="featurelist__item__status">
{% if proposal.presented | size %}
{% for presentation in proposal.presented %}
<li class="featurelist__item__presented">
<a href="{{ presentation.url }}">{{ presentation.date }}</a>
</li>
{% endfor %}
{% endif %}
</li>
<li class="featurelist__item__tests">
<p>Test(s)</p>
{% if proposal.tests | size %}
<p>{% for url in proposal.tests %}<a href="{{ url }}">{{ url }}</a>{% endfor %}</p>
{% else %}
<p>–</p>
{% for url in proposal.tests %}
<li class="featurelist__item__tests">
<a href="{{ url }}">Tests</a>
</li>
{% endfor %}
{% endif %}
</li>
<li class="featurelist__item__spec">
<p>Specification</p>
{% if proposal.specification %}
<a href="{{ proposal.specification }}">{{ proposal.specification }}</a>
{% else %}
<p>–</p>
<li class="featurelist__item__spec">
<a href="{{ proposal.specification }}">Specification</a>
</li>
{% endif %}
</li>
</ul>
</div>
{% if proposal.example %}
</ul>
</section>
</section>
<section class="featurelist__item__author">
{% if proposal.authors | size %}
Author(s):
{{ proposal.authors | join: ", " }}
{% endif %}
{% if proposal.champions | size %}
|
Champion(s):
{{ proposal.champions | join: ", " }}
{% else %}
{% endif %}
</section>
{% if proposal.description %}
<section class="featurelist__item__desc">{{ proposal.description }}</section>
{% endif %}
{% if proposal.example %}
<div class="featurelist__item__example">Show Example</div>
{% endif %}
<section class="featurelist__item__info" tabindex="-1">
{% if proposal.example %}
<div>
<h5>Example</h5>
<pre><code class="js">{{ proposal.example }}</code></pre>
<div>
<pre><code class="js">{{ proposal.example }}</code></pre>
</div>
</div>
{% endif %}
</div>
{% if proposal.resources | size %}
<h5>Developer Resources</h5>
<ul class="featurelist__item__ressources">
{% for url in proposal.resources %}
<li>
<a href="{{ url }}">{{ url }}</a>
</li>
{% endfor %}
</ul>
{% endif %}
</section>
</header>
</section>
</section>
{% endfor %}
</div>
<section class="featurelist__more">
<a href="https://github.com/tc39/proposals">
See more proposals
</a>
</section>
</section>
6 changes: 0 additions & 6 deletions _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@ <h1 class="page-title">Specifying JavaScript.</h1>
{% include intro.html %}
{% include proposals.html %}
</section>
<section class="footer">
<span class="footer-item">
<a href="https://github.com/tc39" class="btn menu-btn">GitHub</a>
</span>

</section>
</main>

<div class="popup">
Expand Down
4 changes: 4 additions & 0 deletions _sass/_content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@
@media (min-width: $bp-tablet) {
padding: 130px 0;

.section-headline {
border-bottom: none;
}

h3 {
margin-left: -40px;
margin-right: -40px;
Expand Down
156 changes: 124 additions & 32 deletions _sass/_featurelist.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,57 +1,108 @@
.featurelist {
&__item {
background-color: white;
border-bottom: 1px solid $color-spacer;
font-size: 0.9em;
margin-bottom: 1.125rem;
padding: 0 1rem 0 1rem;
&__intro {
cursor: pointer;
h4::before {
background: url(../img/menu-down.svg) no-repeat 50%;
background-size: 1.5rem;
content: "";
display: block;
float: right;
height: 1.5rem;
margin-left: 0.5rem;
transition: transform 600ms ease;
width: 1.5rem;
.open & {
transform: rotateX(180deg);
}
[dir="rtl"] & {
float: left;
margin-left: 0;
margin-right: 0.5rem;
}
}
}
&__info {
max-height: 0;
overflow: hidden;
transition: max-height 600ms ease;
}
&__ressources {
a {
word-break: break-all;
}
}
&__status {
clear: both;
float: left;
font-size: 0.8em;
list-style: none;
margin-top: 0;
padding: 0;
li {
align-items: flex-start;
display: flex;
flex-wrap: wrap;
justify-content: space-between;
padding: 0.5rem;
&:nth-of-type(odd) {
background: #eee;
}
}
a {
word-break: break-all;
}
li {
display: inline-block;
margin-top: 0.5rem;
opacity: 1;
padding-left: 0.5rem;
padding-right: 0.5rem;
&:hover {
background-color: transparent;
}
a {
color: white;
text-decoration: none;
}
}
p {
margin: 0;
}
@media (min-width: $bp-tablet) {
clear: none;
float: right;
margin-top: 0.5rem;
padding: 0 5px;
}
}
&__ressources {
a {
word-break: break-all;
h4 {
display: inline-block;
float: left;
font-size: 1.6em;
margin-bottom: 0.5em;
margin-top: 1em;
padding-bottom: 0;
padding-top: 0;
word-wrap: anywhere;
a {
text-decoration: none;
}
}
&__tests {
background-color: $tag-tests;
border: 2px solid $tag-tests;
border-radius: 10px;
&:hover {
a {
color: $tag-tests;
}
}
}
&__spec {
background-color: $tag-spec;
border: 2px solid $tag-spec;
border-radius: 10px;
&:hover {
a {
color: $tag-spec;
}
}
}
&__presented {
background-color: $tag-presented;
border: 2px solid $tag-presented;
border-radius: 10px;
&:hover {
a {
color: $tag-presented;
}
}
}
&__impl {
background-color: $tag-presented;
border: 2px solid $tag-presented;
border-radius: 10px;
&:hover {
a {
color: $tag-tests;
}
}
}
.no-js &:focus-within &__info {
Expand All @@ -60,11 +111,52 @@
.no-js &:focus-within &__intro h4::after {
transform: rotateX(180deg);
}
&__desc {
clear: both;
display: block;
margin: 1em 0 1em 0;
padding: 0;
}
&__author {
clear: both;
color: grey;
font-weight: 800;
margin: 0;
padding-top: 0;
}
&__example {
display: inline-block;
font-weight: 800;
margin-bottom: 1rem;
text-decoration: underline;
&::before {
background: url(../img/menu-down.svg) no-repeat 20%;
background-size: 1.2rem;
content: "";
display: block;
float: right;
height: 1.2em;
margin-left: 0.5rem;
transition: transform 600ms ease;
width: 1.2rem;
.open & {
transform: rotateX(180deg);
}
[dir="rtl"] & {
float: left;
margin-left: 0;
margin-right: 0.5rem;
}
}
}
}
&__desc {
display: block;
font-size: 1.1em;
margin-bottom: 4.5em;
margin-top: 2em;
}
&__more {
text-align: center;
}
}
17 changes: 16 additions & 1 deletion _sass/_grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,31 @@
.g-row {
.intro {
margin: 0 ($grid-gutter / -2) (2 * $grid-gutter);
[class*="g-col-"] {
padding: 0 $grid-gutter / 2;
}
}
.g-row {
@media (min-width: $bp-tablet) {
display: flex;
flex-direction: row;
.flex-grow {
flex-grow: 1;
}
.flex-shrink {
flex-shrink: 1;
}
.g-col-2 {
flex: 0 0 200px;
}
.g-col-4 {
flex: 0 0 percentage(4/12);
}
.g-col-8 {
flex: 0 0 percentage(8/12);
}
.g-col-10 {
flex: 0 0 percentage(10/12);
flex-grow: 2;
}
}
}
Loading