fix #147, make element focus more obvious #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, depending on the browser being used, it may
have been quite difficult to see which element was in focus when
navigating the page using the tab key. This has been corrected by
adjusting the `:focus` pseudo-class styles for selectable elements
so that it no longer depends on inconsistent user-agent styles.
Notes:
https://user-images.githubusercontent.com/17770407/87440188-b38cdc80-c5bf-11ea-86e3-8b1c8652e25b.png
https://user-images.githubusercontent.com/17770407/87440518-141c1980-c5c0-11ea-964f-70ff56523438.png
Fixes: tc39#147
DerekNonGeneric
force-pushed
the
a11y/obvious-focus
branch
from
1c124ca to
6b34153
Compare
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, depending on the browser being used, it may
have been quite difficult to see which element was in focus when
navigating the page using the tab key. This has been corrected by
adjusting the
:focuspseudo-class styles for selectable elementsso that it no longer depends on inconsistent user-agent styles.
Notes:
https://user-images.githubusercontent.com/17770407/87440188-b38cdc80-c5bf-11ea-86e3-8b1c8652e25b.png
https://user-images.githubusercontent.com/17770407/87440518-141c1980-c5c0-11ea-964f-70ff56523438.png
Fixes: #147
Aside: Although it may not have been completely obvious, it should
probably be noted that #147 may have been mostly addressed in #160.