-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix external CSS stylesheet links for html files within doc sub-directories #39
Conversation
…hin docs/ instead of the rforge hosted file; head template is edited for dldoc runs) for doc sub-directories
no need for two copies css file. did you find the button / arrow to mark pull request as a draft? https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request |
Yup thought so, I made the changes and yes, I did find the button, I'll use it for PRs which I'm working on and which are not ready to be merged right away! |
Some more changes to the templates could include:
@tdhock what do you think? I can create another PR for these if deemed suitable |
yes please update the templates |
okay, which link of yours should I put for the contact? |
code version 2014.1.27 | ||
(svn revision 675) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be changed eventually, is now a good time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I'll do it now, thanks for pointing that out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is difficult/impossible for me to review this PR because there are so many changes (103 files changed). |
That's true. The changes are same for each and every html file under plots/ and posfuns/ under different plot-type directories, so you can just check any one file (rest assured, the rest are same). It is ready to be merged! |
Here is the breakdown of changes just to view: (apart from deletion of the copy of estilo1.css)
|
thanks |
The links to the estilo1 CSS file mentioned in the html files within the folders inside doc/ (just saw this while browsing through them) were also linked to the rforge hosted file (http://directlabels.r-forge.r-project.org/estilo1.css), which is not accessible outside, so I changed them to link back to the CSS file in docs/ (I could have also used the one in /root, should I just keep one copy of the css file?) and did the same in templates/head.html for automatic updation when using dldoc
(For example, you can check https://tdhock.github.io/directlabels/docs/contourplot/posfuns/bottom.pieces.html and http://directlabels.r-forge.r-project.org/docs/contourplot/posfuns/bottom.pieces.html to see the difference before merging this)
@tdhock If you find anything falling behind or lacking in https://tdhock.github.io/directlabels/ with respect to the rforge hosted website (http://directlabels.r-forge.r-project.org/), then let me know!