[MOD] 곡 상세+나의 뮤멘트 API - request-body보내지 않으면 400 핸들링 #145

team-MUMENT · Feb 5, 2023 · f10f4d0 · f10f4d0
1 parent b82667b
commit f10f4d0
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 13 deletions.
diff --git a/dist/controllers/MusicController.js b/dist/controllers/MusicController.js
diff --git a/dist/controllers/MusicController.js.map b/dist/controllers/MusicController.js.map
diff --git a/dist/routes/MusicRouter.js b/dist/routes/MusicRouter.js
diff --git a/dist/routes/MusicRouter.js.map b/dist/routes/MusicRouter.js.map
diff --git a/src/controllers/MusicController.ts b/src/controllers/MusicController.ts
@@ -13,16 +13,15 @@ import { MusicCreateDto } from '../interfaces/music/MusicCreateDto';
  * @DESC 곡 상세보기 뷰에서 music 정보와 나의 뮤멘트 정보 가져오기
  */
 const getMusicAndMyMument = async (req: Request, res: Response) => {
-    const { musicId } = req.params;
-    const userId = req.body.userId;
-    const musicCreateDto: MusicCreateDto = req.body;
-
     const error = validationResult(req);
-
     if (!error.isEmpty()) {
-        return res.status(statusCode.BAD_REQUEST).send(util.fail(statusCode.BAD_REQUEST, message.WRONG_PARAMS));
+        return res.status(statusCode.BAD_REQUEST).send(util.fail(statusCode.BAD_REQUEST, message.BAD_REQUEST));
     }
 
+    const { musicId } = req.params;
+    const userId = req.body.userId;
+    const musicCreateDto: MusicCreateDto = req.body;
+
     try {
         const data = await MusicService.getMusicAndMyMument(musicId, userId, musicCreateDto);
 

diff --git a/src/routes/MusicRouter.ts b/src/routes/MusicRouter.ts
@@ -8,7 +8,11 @@ const router: Router = Router();
 router.get('/search', MusicController.getMusicListBySearch);
 
 router.post('/:musicId', [
-    param('musicId').toInt().isInt(), 
+    param('musicId').toInt().isInt(),
+    body('musicId').notEmpty(),
+    body('musicArtist').notEmpty(),
+    body('musicImage').notEmpty(),
+    body('musicName').notEmpty(),
 ], auth, MusicController.getMusicAndMyMument);
 
 router.get('/:musicId/order', [