[refactor/#91] 문항세트 조회 api 리팩토링 #93
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| package com.moplus.moplus_server.domain.problemset.repository; | ||
|
|
||
| import static com.moplus.moplus_server.admin.publish.domain.QPublish.*; | ||
| import static com.moplus.moplus_server.domain.concept.domain.QConceptTag.*; | ||
| import static com.moplus.moplus_server.domain.problem.domain.problem.QProblem.*; | ||
| import static com.moplus.moplus_server.domain.problem.domain.childProblem.QChildProblem.*; | ||
|
|
||
| import com.moplus.moplus_server.admin.problemset.dto.response.ProblemSetGetResponse; | ||
| import com.moplus.moplus_server.admin.problemset.dto.response.ProblemSummaryResponse; | ||
| import com.moplus.moplus_server.domain.problemset.domain.ProblemSet; | ||
| import com.querydsl.core.Tuple; | ||
| import com.querydsl.jpa.impl.JPAQueryFactory; | ||
| import java.time.LocalDate; | ||
| import java.util.*; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Repository | ||
| @RequiredArgsConstructor | ||
| public class ProblemSetGetRepositoryCustom { | ||
|
|
||
| private final JPAQueryFactory queryFactory; | ||
|
|
||
| public ProblemSetGetResponse getProblemSet(ProblemSet problemSet) { | ||
| // 발행 날짜 조회 쿼리 | ||
| List<LocalDate> publishedDates = queryFactory | ||
| .select(publish.publishedDate) | ||
| .from(publish) | ||
| .where(publish.problemSetId.eq(problemSet.getId())) | ||
| .fetch(); | ||
|
|
||
| // 문항 및 새끼문항 조회 | ||
| List<Tuple> problemData = queryFactory | ||
| .select( | ||
| problem.id, | ||
| problem.problemCustomId.id, | ||
| problem.title.title, | ||
| problem.memo, | ||
| problem.mainProblemImageUrl | ||
| ) | ||
| .from(problem) | ||
| .leftJoin(problem.childProblems, childProblem) // 자식 문제 JOIN | ||
| .where(problem.id.in(problemSet.getProblemIds())) | ||
| .distinct() | ||
| .fetch(); | ||
|
|
||
| // 문항 및 새끼 문항의 개념 태그 조회 | ||
| List<Long> allProblemIds = problemSet.getProblemIds(); // 문제 ID 목록 | ||
| List<Long> childProblemIds = queryFactory | ||
|
There was a problem hiding this comment. 위에서 problem과 childproblem을 fetch join해와서 한번더 조회를 하지않아도 될것 같아요 |
||
| .select(childProblem.id) | ||
| .from(problem) | ||
| .join(problem.childProblems, childProblem) | ||
| .where(problem.id.in(allProblemIds)) | ||
| .fetch(); | ||
|
|
||
| Set<Long> allProblemAndChildProblemIds = new HashSet<>(allProblemIds); | ||
| allProblemAndChildProblemIds.addAll(childProblemIds); // 문제 + 자식 문제 ID 합침 | ||
|
There was a problem hiding this comment. 문항과 새끼문항의 아이디를 set으로 합치는 이유는 어떤걸가요? |
||
|
|
||
| // 문항 및 자식 문항의 개념 태그 조회 | ||
| Map<Long, Set<String>> conceptTagMap = queryFactory | ||
| .select(problem.id, conceptTag.name) | ||
| .from(problem) | ||
| .leftJoin(conceptTag) | ||
| .on(conceptTag.id.in(problem.conceptTagIds)) | ||
| .where(problem.id.in(allProblemAndChildProblemIds)) // 문제 + 자식 문제 ID | ||
|
There was a problem hiding this comment. 문항 테이블에서 새끼 문항 id로 검색하는것 같은데요? |
||
| .fetch() | ||
| .stream() | ||
| .collect( | ||
| HashMap::new, | ||
| (map, tuple) -> map | ||
| .computeIfAbsent(tuple.get(problem.id), k -> new HashSet<>()) | ||
| .add(tuple.get(conceptTag.name)), | ||
| HashMap::putAll | ||
| ); | ||
|
|
||
| List<ProblemSummaryResponse> problemSummaries = problemData.stream() | ||
| .map(tuple -> ProblemSummaryResponse.builder() | ||
| .problemId(tuple.get(problem.id)) | ||
| .problemCustomId(tuple.get(problem.problemCustomId.id)) | ||
| .problemTitle(tuple.get(problem.title.title)) | ||
| .memo(tuple.get(problem.memo)) | ||
| .mainProblemImageUrl(tuple.get(problem.mainProblemImageUrl)) | ||
| .tagNames(conceptTagMap.getOrDefault(tuple.get(problem.id), new HashSet<>())) // 태그 매핑 | ||
| .build() | ||
|
There was a problem hiding this comment. DTO에 대한 정보가 repository까지 내려오는거는 유지보수 관점에서 좋지 않은것 같아요 |
||
| ) | ||
| .toList(); | ||
|
|
||
| return ProblemSetGetResponse.of(problemSet, publishedDates, problemSummaries); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JPA는 select 문에 조회하고 싶은 엔티티를 넣어야지 영속성 컨텍스트에 반영해요
fetch join을 해서 영속성 컨텍스트에 넣어주거나 select 문에 엔티티를 선언해주어야해요