[machine] 완료 직후 상태 표시 지연 수정#101
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the machine status query service to hide active reservation details when the machine's physical state is detected as completed. It also refactors the completion detection logic in MachineStateDetectionSupport to immediately treat a finished job state as completed, even if the reported completion time is in the future. Feedback suggests sharing this completion detection logic with the reservation creation and validation processes to prevent potential data inconsistencies where a user sees a machine as available in the UI but cannot reserve it due to an active reservation remaining in the database.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
개요
SmartThings완료 직후에도 완료 예정 시각과 예약 정보가 잠시 노출되던 문제를 수정했습니다.machineState=stop이고 작업 상태가 완료이면completionTime이 약간 미래로 남아 있어도 완료로 판정하도록 조정했습니다.본문
MachineStateDetectionSupport에서 세탁기finish, 건조기finished상태와machineState=stop조합을 즉시 완료 신호로 처리했습니다.QueryAllMachinesStatusServiceImpl에서 완료 신호가 확인된RUNNING예약은 표시 응답에서 제외해expectedCompletionTime,remainingMinutes, 예약자 정보가 다시 내려가지 않도록 했습니다.테스트:
./gradlew test