Skip to content

[machine] 완료 직후 상태 표시 지연 수정#101

Merged
hej090224 merged 1 commit into
masterfrom
fix/machine-completion-status-display
Jul 18, 2026
Merged

[machine] 완료 직후 상태 표시 지연 수정#101
hej090224 merged 1 commit into
masterfrom
fix/machine-completion-status-display

Conversation

@hej090224

Copy link
Copy Markdown
Member

개요

SmartThings 완료 직후에도 완료 예정 시각과 예약 정보가 잠시 노출되던 문제를 수정했습니다.
machineState=stop이고 작업 상태가 완료이면 completionTime이 약간 미래로 남아 있어도 완료로 판정하도록 조정했습니다.

본문

  • MachineStateDetectionSupport에서 세탁기 finish, 건조기 finished 상태와 machineState=stop 조합을 즉시 완료 신호로 처리했습니다.
  • QueryAllMachinesStatusServiceImpl에서 완료 신호가 확인된 RUNNING 예약은 표시 응답에서 제외해 expectedCompletionTime, remainingMinutes, 예약자 정보가 다시 내려가지 않도록 했습니다.
  • 세탁기와 건조기 완료 판정, 기기 상태 조회 응답 회귀 테스트를 추가했습니다.

테스트:

  • ./gradlew test

@hej090224
hej090224 requested a review from d1ng1724 July 17, 2026 15:37
@hej090224 hej090224 added 버그 애플리케이션의 버그에 대응합니다. and removed bug:버그 labels Jul 17, 2026
@hej090224 hej090224 self-assigned this Jul 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the machine status query service to hide active reservation details when the machine's physical state is detected as completed. It also refactors the completion detection logic in MachineStateDetectionSupport to immediately treat a finished job state as completed, even if the reported completion time is in the future. Feedback suggests sharing this completion detection logic with the reservation creation and validation processes to prevent potential data inconsistencies where a user sees a machine as available in the UI but cannot reserve it due to an active reservation remaining in the database.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@hej090224
hej090224 merged commit b3f1348 into master Jul 18, 2026
1 check passed
@hej090224
hej090224 deleted the fix/machine-completion-status-display branch July 18, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

버그 애플리케이션의 버그에 대응합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants