Skip to content

[feat] 사용중인 호실 표시#15

Merged
LeeSangHyeok0731 merged 1 commit into
mainfrom
feat/washer-roomnumber-display
Jun 10, 2026
Merged

[feat] 사용중인 호실 표시#15
LeeSangHyeok0731 merged 1 commit into
mainfrom
feat/washer-roomnumber-display

Conversation

@LeeSangHyeok0731

@LeeSangHyeok0731 LeeSangHyeok0731 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

개요 💡

누락된 사용중인 호실 표시를 작업했습니다.

스크린샷

image

@LeeSangHyeok0731 LeeSangHyeok0731 requested a review from bom0320 June 10, 2026 00:39
@LeeSangHyeok0731 LeeSangHyeok0731 self-assigned this Jun 10, 2026
@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
washer Ready Ready Preview, Comment Jun 10, 2026 12:39am

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the userRoomNumber field to the reservation data model, maps it from the DTO, and displays it next to the machine name in the ReservationRow component. The reviewer pointed out a potential rendering issue where an empty or missing userRoomNumber could display as "호" or "undefined호", and suggested using conditional rendering to safely display the room number.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/widgets/reservations-page/ui/ReservationRow.tsx
@LeeSangHyeok0731 LeeSangHyeok0731 merged commit bcbf869 into main Jun 10, 2026
3 checks passed
@LeeSangHyeok0731 LeeSangHyeok0731 deleted the feat/washer-roomnumber-display branch June 10, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant