Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

86 test prepare script #88

Conversation

JensWinter
Copy link
Collaborator

I modified prepare.py to basically use a function named create_buffer_shape() now.

Tests check if a base ESRI shape file is converted correctly into buffer shape based on provided buffer distance values. Source shape file and expected test buffer shapes are added as assets.

I had to install GDAL 3.4 to the testing container as I didn't get the requirements.txt installed on the Github runner.

- test default buffer distance
- test custom buffer distance
- test file creation
@JensWinter JensWinter closed this May 1, 2023
@JensWinter JensWinter reopened this May 1, 2023
@JensWinter JensWinter changed the base branch from master to staging May 1, 2023 20:53
@JensWinter JensWinter linked an issue May 1, 2023 that may be closed by this pull request
@sjockers
Copy link
Collaborator

sjockers commented May 3, 2023

Nice! I just started to look into #86 and realized you had already addressed it.

I believe the second check only fails because you've opened the PR from a different repo, which means that the task doesn't have access to the secrets needed to run it. I had the same problem before (see #82).

@JensWinter
Copy link
Collaborator Author

Oh, thanks for the hint, @sjockers. I created another branch on the TSB repo. Seems to work fine.

@JensWinter JensWinter closed this May 3, 2023
@JensWinter JensWinter deleted the 86-test-prepare-script branch May 3, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create workflow to test the prepare script
2 participants