[WIP] Separate symbology and labels from od#509
Draft
cymed wants to merge 115 commits intoteksi:mainfrom
Draft
Conversation
cymed
added
enhancement
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ewater into separate_labels
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
former ws._label is duplicate of ws.identifier
Contributor
Author
|
@ponceta this PR is conflicting with the dump creation, probably because dropping columns makes the restore fail. Docs builder fails because of missing artefacts. How should we solve this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
Describe your changes
Concept of #409, but including symbology.
The PR introduces
tww_od.tww_symbology_quarantinetww_od.tww_reach_point_labelstww_od.tww_wastewater_structure_labelstww_od.tww_wastewater_node_symbologytww_app.vw_tww_wastewater_nodeto include the now separated symbology columns. TODO: currently, moving thevw_tww_wastewater_nodemoves the corresponding reaches/reach points as well. Is this behaviour desired?To-Do
When altering a geometry in
tww_app.vw_tww_wastewater_node, the geometry of the reaches/reach points linked to it are updated too. We need feedback from the user group if this behaviour is desired or not.Screenshots
Issue ticket number and link
Checklist before requesting a review
Checklist before merge