Skip to content

chore: update dependencies and documentation linting rules#2617

Merged
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:update-docs-golang-lint
Mar 27, 2026
Merged

chore: update dependencies and documentation linting rules#2617
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:update-docs-golang-lint

Conversation

@chmouel
Copy link
Copy Markdown
Member

@chmouel chmouel commented Mar 27, 2026

[forgot to do that in the other updates deps pr]

Bumped Go version to 1.26 in Tekton CI tasks and updated codespell to v2.4.2. Additionally, added a Vale rule to prevent session ID exposure in URLs, adjusted bare-metal term mappings, and updated UBI images in test data.

📝 Description of the Change

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

Bumped Go version to 1.26 in Tekton CI tasks and updated codespell to
v2.4.2. Additionally, added a Vale rule to prevent session ID
exposure in URLs, adjusted bare-metal term mappings, and updated UBI
images in test data.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the codespell pre-commit hook, introduces a new Vale style for session ID detection, and refines several RedHat-specific terminology rules. It also attempts to upgrade Go and UBI image versions across multiple Tekton configuration files and test data. Feedback indicates that the specified Go 1.26 and UBI 10 images are not yet available, which would cause CI failures. Furthermore, it is recommended to include the -race flag when running Go tests to detect potential concurrency bugs.

@chmouel chmouel merged commit 56a3a61 into tektoncd:main Mar 27, 2026
13 checks passed
@chmouel chmouel deleted the update-docs-golang-lint branch March 27, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants