Skip to content

fix: update stepaction url in test data#2620

Open
chmouel wants to merge 3 commits intotektoncd:mainfrom
chmouel:update-pipelinerun-stepactions-url
Open

fix: update stepaction url in test data#2620
chmouel wants to merge 3 commits intotektoncd:mainfrom
chmouel:update-pipelinerun-stepactions-url

Conversation

@chmouel
Copy link
Copy Markdown
Member

@chmouel chmouel commented Mar 28, 2026

Corrected the repository URL for the git-clone stepaction to point to the tektoncd organization.
This was a bad merge after #2619

When forking spend, loop until we can do the fork (up to 30s) for GitlabFork

📝 Description of the Change

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

Corrected the repository URL for the git-clone stepaction to point to
the tektoncd organization.

This was a bad merge after tektoncd#2619
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository URL for the git-clone step action in the test data, changing the organization from pipelines-as-code to tektoncd. I have no feedback to provide.

chmouel added 2 commits March 28, 2026 07:30
When a second GitLab user is added as Developer to a project and
immediately attempts to fork it, GitLab may return 404 because the
membership has not yet propagated to the fork API. Add a retry loop
with 5s sleep up to a 30s deadline in ForkGitLabProject to handle
this race condition.

Assisted-by: Claude Sonnet 4.6 (via Claude Code)
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Introduced a helper script to manage gotestsum binary installation
across CI environments. Replaced make targets with gotestsum to improve
test reporting and consistency in Tekton pipelines and GitHub Actions.

This allows output to json and stdout at the same time
@chmouel
Copy link
Copy Markdown
Member Author

chmouel commented Mar 28, 2026

@zakisk added that as well dc8d0a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant