-
Notifications
You must be signed in to change notification settings - Fork 127
fix: Rails 8.1 incompatibility config_accessor #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Logger functionality in ActionController implemented using AbstractController::Logger class. Following change fixes incompatibility with Rails 8.1.
|
I get |
|
I've tested this PR, works great for me. Would appreciate a merge, @printercu |
|
Test fails |
|
@mprokopov would you update the test? I am still on this PR |
|
@printercu most likely the bug goes away if you update your ruby version |
|
the test seems to fail on presumably unrelated problem
|
|
it's basically a known bug with a openssl incompatibility if you don't explicitly include openssl as a gem with older ruby versions. |
|
@printercu @mprokopov I find it a bit disappointing that Rails 8.1 is out since nearly 3 months and one has still to rely on a fixed b8ebc2d hash commit. How can we get official 8.1 support merged in the Gem? |
Logger functionality in ActionController implemented using AbstractController::Logger class. Following change fixes incompatibility with Rails 8.1.
Resolves #263