Add Github action for running Storybook tests #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
force-pushed
the
DT-2155-run-storybook-tests
branch
from
27167a1 to
fb92b8c
Compare
laurakwhit
requested review from
stevekinney,
rossedfort and
a team
as code owners
rossedfort
requested changes
Jun 17, 2024
Comment on lines
+12
to
+13
| - name: Install Playwright | ||
| run: pnpm exec playwright install --with-deps |
There was a problem hiding this comment.
I'm curious why we need to install the Playwright browsers for the Storybook tests 🤔
There was a problem hiding this comment.
test-runner uses Playwright and I assume for visual tests they are being run in the browser. I followed the example here.
rossedfort
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
pnpm stories:testpnpm test:coverageScreenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2155Docs
Any docs updates needed?