Include Local Activity failure in filter for Pending and Failed Events #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
approved these changes
Mar 7, 2025
laurakwhit
added a commit
that referenced
this pull request
Mar 10, 2025
* Support messageType metadata on protobuf encoded Payloads (#2581) * WIP: add messageType metadata field for json/protobuf payloads. Need to add messageType to schedules/signals * Set existing messageType and encoding on start workflow if it exists, add to signal * Add gap * Url encode deployment name (#2585) * Don't query metadata if no pollers available (#2586) * Include Local Activity failure in filter for Pending and Failed Events (#2588) * Add local activity failure to filter * Add unit tests, refactor logic, standarized and clean up pending rows --------- Co-authored-by: Alex Tideman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
For our Pending/Failed filter, we look for Activity Task Failed events for Activities. Users would like to also include Local Activity failures, which is determined by the failure field in attributes.
I also cleaned up our Pending Activity/Nexus rows to be consistent.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?