Skip to content

Add TODO issues for ParseTime on Windows #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Add TODO issues for ParseTime on Windows #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion except.txt
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions tensorflow_addons/text/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ licenses(["notice"]) # Apache 2.0
package(default_visibility = ["//visibility:public"])

# TODO: Once TF exports symbols in a DLL we can enable parse_time_op for windows
# https://github.com/tensorflow/addons/issues/782
py_library(
name = "text",
srcs = select({
Expand Down
3 changes: 2 additions & 1 deletion tensorflow_addons/text/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@

# Parse Time

# Temporarily disable for windwos
# Temporarily disable for windows
# Remove after: https://github.com/tensorflow/addons/issues/782
import os
if os.name != 'nt':
from tensorflow_addons.text.parse_time_op import parse_time
2 changes: 2 additions & 0 deletions tensorflow_addons/text/parse_time_dummy_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
from __future__ import absolute_import
from __future__ import division
from __future__ import print_function

# Remove after: https://github.com/tensorflow/addons/issues/782