This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated type inference behavior was changed in swiftlang/swift#32578:
derived conformances are now attempted before associated type inference.
This broke
ParameterlessLayer
, which relied on aTangentVector == EmptyTangentVector
same-type constraint to set adefault
TangentVector
type witness for conforming types.Add explicit
TangentVector
type witnesses toParameterlessLayer
-conforming types to fix this regression.This workaround is forward- and backward-compatible, but makes code
more verbose.
This regression after swiftlang/swift#32578 is unfortunate, especially because
there doesn't seem to exist a workaround that doesn't produce a warning.
I'll write a minimal regression reproducer and ask on the PR if there's some principled
way to support the old behavior.
Fixes build errors from the 2020-06-30
master -> tensorflow
merge: