Skip to content

Fix Cart-Pole Render Angle #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kinvert
Copy link

@Kinvert Kinvert commented Apr 3, 2025

When rendering Cart Pole, the pole is at the wrong angle. This one liner fixes it.

I saw you want issues created. I didn't see how to do it here so I followed the link you provided in your README.md and it went to another repo. I created the issue here: tensorflow/tfjs#8538

My son and I noticed it when I was trying your demo. I dug through the code and found this, and the sign swap works.

Copy link

google-cla bot commented Apr 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Kinvert
Copy link
Author

Kinvert commented Apr 3, 2025

For some reason your CLA thing is tying to other accounts instead of my GitHub account. I tried opening in a private window and it wants me to sign in with my Google account. That has a different email address. How do I sign this CLA without mixing up email addresses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant