Skip to content

Conversation

@ramamalladiTT
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 5, 2026 13:09
@ramamalladiTT ramamalladiTT requested a review from lyen1 as a code owner February 5, 2026 13:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request ports the ScaledYOLOv4 object detection model to the Polaris platform using ttsim (TensTorrent Simulator). The PR adds comprehensive validation infrastructure comparing ttsim implementations against PyTorch reference implementations.

Changes:

  • Adds ScaledYOLOv4 model implementation with ttsim-compatible modules
  • Implements validation scripts for 18+ common modules and 2 YOLO-specific modules
  • Extends ttsim core to support data propagation through operations (Conv2d, BatchNorm, MaxPool, etc.)
  • Adds new operations (Mish, ReLU6, AdaptiveAvgPool2d) to ttsim
  • Includes configuration files for workload registration

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 26 comments.

Show a summary per file
File Description
workloads/ScaledYOLOv4/reference/yolo/run_all.py Orchestrates YOLO module validations (Detect, Model)
workloads/ScaledYOLOv4/reference/yolo/results.md Pre-generated validation results (2/2 modules passed)
workloads/ScaledYOLOv4/reference/yolo/detect.py Validates Detect layer against PyTorch
workloads/ScaledYOLOv4/reference/common/run_all.py Orchestrates common module validations (18 modules)
workloads/ScaledYOLOv4/reference/common/results.md Pre-generated validation results (18/18 passed)
workloads/ScaledYOLOv4/reference/common/*.py Individual module validation scripts
workloads/ScaledYOLOv4/models/experimental.py Experimental modules (CrossConv, C3, GhostConv, etc.)
workloads/ScaledYOLOv4/models/utils/*.py Utility functions adapted for ttsim
workloads/ScaledYOLOv4/README.md Documentation for workload validation
ttsim/ops/desc/*.py Core ttsim extensions for data propagation
ttsim/front/functional/op.py New operation definitions (Mish, ReLU6, AdaptiveAvgPool2d)
config/*.yaml Configuration for workload registration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ssapreTT
Copy link
Contributor

Can some tests be added to test this content?

Test Categories:

  • Numerical operations - numerical correctness, edge cases (0, -ve), verify output shapes
  • Module Classes etc - different input dimensions, output shape validation, correct compute / memory work estimates for known sizes

Across all these categories:

  • Compare w.r.t. reference outputs
  • Vary inputsEdge cases
  • Error handling / exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants