-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a QuestionAnswering bert model for testing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se bfloat16 when initializing the model
kwargs=new_kwargs, | ||
new_kwargs = { | ||
"fill_value": args[1], | ||
"device": DummyDevice(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
Comment on lines
+353
to
+359
memory_config = g.call_function( | ||
ttnn.MemoryConfig, | ||
( | ||
DummyTtlTensorTensorMemoryLayoutInterleaved(), | ||
DummyTtlTensorBufferTypeDram(), | ||
), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help to understand whats going on here?
ayerofieiev-tt
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#10
Problem description
We want a separate unit test for bert. The
run_transformers.py
script has the initial implementation, and this PR separates that into a unit test.What's changed
test_bert.py
that runs the reference and compiled model using ttnn backend and compare the inference results.aten.full
when scalars are passed to certain ops. Usettnn.full instead
aten._to_copy
tottnn.as_tensor