Simplify testing of models to minimize extra code #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevinwuTT
commented
Jul 30, 2024
kevinwuTT
commented
- Add Pytest autouse fixture that compiles a model and records metrics for original and compiled run
- Models no longer need to import ttnn or torch_ttnn modules
- Models will need to register a few lines of information for this fixture to work
- Simplify the collect metrics script
- No longer need to hard-code a map of model paths
- No longer need to import output artifacts to calculate accuracy
- Accuracy is calculated in the pytest fixture directly
| @@ -15,3 +22,61 @@ def reset_torch_dynamo(): | |||
| # PyTorch caches models. Start a fresh compile for each parameter of the test case. | |||
| torch._dynamo.reset() | |||
| yield | |||
|
|
|||
|
|
|||
| @pytest.fixture(autouse=True) | |||
There was a problem hiding this comment.
does autouse apply it to lowering tests too?
There was a problem hiding this comment.
Checked on a call. Yes.
We agreed it is ok for now.
We agreed this will go away during the next step.
ayerofieiev-tt
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.