#0: Add missing MeshBuffer APIs #18817
Conversation
| uint32_t num_pages() const { return page_size() == 0 ? 0 : device_local_size_ / page_size(); } | ||
| uint32_t num_dev_pages() const; |
There was a problem hiding this comment.
This is used in one op: ttnn/cpp/ttnn/operations/data_movement/sharded/reshard/device/reshard_program_factory.cpp
| uint32_t num_dev_pages() const; | ||
|
|
||
| BufferType buffer_type() const { return device_local_config_.buffer_type; } | ||
| CoreType core_type() const; |
There was a problem hiding this comment.
Used in: ttnn/cpp/ttnn/operations/data_movement/sharded/reshard/device/reshard_program_factory.cpp only as well
| bool is_trace() const; | ||
|
|
||
| bool is_valid_region(const BufferRegion& region) const; | ||
| bool is_valid_partial_region(const BufferRegion& region) const; |
There was a problem hiding this comment.
These two are only used in tests/tt_metal/tt_metal/api/test_buffer_region.cpp and tt_metal/impl/buffers/dispatch.cpp
|
|
||
| TensorMemoryLayout buffer_layout() const { return device_local_config_.buffer_layout; } | ||
|
|
||
| bool bottom_up() const { return device_local_config_.bottom_up.value(); } |
There was a problem hiding this comment.
No ttnn uses, but used in allocator/global_semaphore/lightmetal
| bool bottom_up() const { return device_local_config_.bottom_up.value(); } | ||
|
|
||
| DeviceAddr page_address(uint32_t bank_id, uint32_t page_index) const; | ||
| DeviceAddr bank_local_page_address(uint32_t bank_id, uint32_t page_index) const; |
There was a problem hiding this comment.
These two are used in metal api, and ttnn reports
| std::optional<uint32_t> num_cores() const; | ||
| const std::shared_ptr<const BufferPageMapping>& get_buffer_page_mapping(); | ||
| std::optional<SubDeviceId> sub_device_id() const; | ||
| size_t unique_id() const { return unique_id_; } |
There was a problem hiding this comment.
This is just used in lightmetal + ttnn/cpp/ttnn/graph/graph_processor.cpp
Let's discuss which Buffer API functions we want to add in MeshBuffer. Per Joseph, there's a bunch of convenience methods that we would like to get in (
allocator(),is_l1(),buffer_layout(),bottom_up(), etc.), but it's not quite clear which others we'll need for the ttnn integration.For now, the commit here has every single function implemented, and I can drop blocks of them as we deem fit.