Output shape verification for reduce ops #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azecevicTT
requested review from
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
jserbedzijaTT,
jnie-TT,
nsmithtt,
vroubtsovTT and
mrakitaTT
as code owners
sdjordjevicTT
approved these changes
Mar 6, 2025
azecevicTT
force-pushed
the
azecevic/reduction-verifier
branch
from
09c6aba to
f118a37
Compare
vroubtsovTT
approved these changes
Mar 6, 2025
odjuricicTT
pushed a commit
that referenced
this pull request
Mar 8, 2025
### Ticket Closes #2369 ### Problem description Some erroneous shapes would pass verification and only fail in the runtime due to wrong interpretation of `dim_arg` when its value is `nullopt`. There is an example in the linked issue. ### What's changed - Added verification when `dim_arg` is nullopt in TTNN - Added a shape verification in TTIR - Added negative tests ### Checklist - [x] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #2369
Problem description
Some erroneous shapes would pass verification and only fail in the runtime due to wrong interpretation of
dim_argwhen its value isnullopt. There is an example in the linked issue.What's changed
dim_argis nullopt in TTNNChecklist