Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CB operands from ttir.generic #2376

Merged
merged 6 commits into from
Mar 6, 2025
Merged

remove CB operands from ttir.generic #2376

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36a886a
simplify DPS inheritance using utils::getDpsOutputs()
vroubtsovTT Feb 27, 2025
ffdd627
rm CB operands from ttir.generic
vroubtsovTT Mar 5, 2025
46612ac
move getDpsOutputs() helper into tt::ttir and a dialect-specific Utils.h
vroubtsovTT Mar 5, 2025
a169fc7
add newline at EOF
vroubtsovTT Mar 5, 2025
f14ba54
edits to address PR feedback
vroubtsovTT Mar 5, 2025
513445e
final simplification
vroubtsovTT Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions include/ttmlir/Dialect/TTIR/IR/TTIROps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,17 @@
#include "ttmlir/Dialect/TT/IR/TTOpsTypes.h"
#include "ttmlir/Dialect/TTIR/IR/TTIROpsInterfaces.h"
#include "ttmlir/Dialect/TTIR/IR/TTIRTraits.h"

#include "mlir/Bytecode/BytecodeOpInterface.h"
#include "mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h"
#include "mlir/IR/BuiltinTypes.h"
#include "mlir/IR/OpDefinition.h"
#include "mlir/IR/PatternMatch.h"
#include "mlir/Interfaces/ControlFlowInterfaces.h"
#include "mlir/Interfaces/DestinationStyleOpInterface.h"
#include "mlir/Interfaces/InferTypeOpInterface.h"
#include "mlir/Interfaces/SideEffectInterfaces.h"
#include "ttmlir/Dialect/TTIR/IR/Utils.h"

#include <mlir/Bytecode/BytecodeOpInterface.h>
#include <mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h>
#include <mlir/IR/BuiltinTypes.h>
#include <mlir/IR/OpDefinition.h>
#include <mlir/IR/PatternMatch.h>
#include <mlir/Interfaces/ControlFlowInterfaces.h>
#include <mlir/Interfaces/DestinationStyleOpInterface.h>
#include <mlir/Interfaces/InferTypeOpInterface.h>
#include <mlir/Interfaces/SideEffectInterfaces.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the chevrons here goes against our style guide (inherited from llvm).

See https://docs.tenstorrent.com/tt-mlir/coding-guidelines.html#includes

Copy link
Contributor Author

@vroubtsovTT vroubtsovTT Mar 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always used <> for all includes that are external to the project's source tree and thus need an include path provided to the compiler. Also have done this in several prev PRs...

Changed in the last commit.


namespace mlir::tt::ttir {

Expand Down
Loading
Loading