Added sum, min, max support and tests for TTIR Builder #2404
+96
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctodTT
approved these changes
Mar 7, 2025
python/test_infra/ttir_builder.py
Outdated
Comment on lines
419
to
430
| if op_ttir_function in [ttir.MaxOp, ttir.MinOp]: | ||
| golden = Golden( | ||
| op_golden_function( | ||
| *(organize_golden_args(inputs)), | ||
| golden_kwargs["dim"][0], | ||
| golden_kwargs["keepdim"], | ||
| )[0] | ||
| ) | ||
| else: | ||
| golden = Golden( | ||
| op_golden_function(*(organize_golden_args(inputs)), **golden_kwargs) | ||
| ) |
There was a problem hiding this comment.
Out of curiosity, why isn't the kwarg expansion sufficient here? I assume it's some weird inconsistency in how torch.{min,max} are called, but I can't see it. No need to change this if it's the only way to make it work.
There was a problem hiding this comment.
Yeah, I’m not thrilled with this solution, if you have a more elegant/scalable way lmk. But torch.max and min expect an int or name as the second argument whereas other torch functions expect a tuple of ints or names. They both also return torch.return_types.max(tensor, tensor) instead of a tensor.
There was a problem hiding this comment.
Nevermind, see most recent commit
tapspatel
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#1539
Problem description
Not all TTIR ops are supported by TTIR builder.
What's changed
Added support in ttir_builder.py for ops sum, max, min.
Added tests in test_ttir_ops.py.
Checklist