-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix systemd service starting in postinst #5
base: main
Are you sure you want to change the base?
Fix systemd service starting in postinst #5
Conversation
@@ -1,5 +1,5 @@ | |||
hugepages-setup.sh /opt/tenstorrent/bin | |||
tenstorrent-hugepages.service /lib/systemd/system/ | |||
dev-hugepages\\x2d1G.mount /lib/systemd/system/ | |||
debian/tenstorrent-hugepages.service /lib/systemd/system/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these files aren't in the debian/ directory, and changing this will mess up the .deb file creation itself (and if it works it won't have these files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved these files to the debian dir in the PR, you should be able to see those changes also in the PR (github lists them as renames)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they should not be in the debian directory as we'll need those when we generate non-debs as well, so it doesn't make sense for those to be there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debhelper
seems to generate the postinst
and postrm
steps (the part where the services get started and cleaned up) properly only if these files are in the debian directory. I download the deb files of a couple of packages (sshd, mariadb) and they all have the systemd service files within the debian dir in them. So I thought that this was the right place to keep these files.
Since you are saying that we will need them for non-debian distros as well, do you have a suggestion for a way to accomplish this? Creating a copy or copying the file into the debian dir during the build process or something better?
eca25c7
to
29ba4dc
Compare
bba909a
to
9c64e40
Compare
Signed-off-by: Anirudh Srinivasan <[email protected]>
9c64e40
to
d67975a
Compare
Summary
The
tenstorrent-hugepages.service
anddev-hugepages-1G.mount
services are not being started and enabled after the installation of the tenstorrent-tools debian package.In cloud, we have to manually start these 2 services. It might be simpler for the end user (once this package is released) if this step could be skipped.
Fix
debhelper
should automatically generate a postinst step that enables systemd services that are present inside thedebian
folder. The existing postinst script has a#DEBHELPER#
portion added that will be replaced with the part that starts the systemd services. A postrm step will also added to disable/remove the service when the package is uninstalled.The 2 services (
tenstorrent-hugepages
anddev-hugepages-1G
) are moved to the debian folder to reflect this.