Explain harvesting mask in soc descriptor #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
pjanevskiTT
approved these changes
Feb 24, 2025
| @@ -122,6 +122,15 @@ class tt_SocDescriptor { | |||
| int eth_l1_size; | |||
| bool noc_translation_id_enabled; | |||
| uint64_t dram_bank_size; | |||
|
|
|||
| // Harvesting mask is reported in logical coordinates, meaning the index of a bit that is set corresponds to the | |||
| // index of the row (in case of Tensix), or the index of the channel (in case of DRAM), or the index of the core | |||
There was a problem hiding this comment.
nit: index of the row (Wormhole) or column (Blackhole)
| @@ -122,6 +122,15 @@ class tt_SocDescriptor { | |||
| int eth_l1_size; | |||
| bool noc_translation_id_enabled; | |||
| uint64_t dram_bank_size; | |||
|
|
|||
| // Harvesting mask is reported in logical coordinates, meaning the index of a bit that is set corresponds to the | |||
| // index of the row (in case of Tensix), or the index of the channel (in case of DRAM), or the index of the core | |||
There was a problem hiding this comment.
nit: for ETH we also call it channel, maybe better than core. You can decide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Updating a comment to make harvesting masks clearer
List of the changes
Testing
API Changes