Implement changes to run tests on P300 #593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Run UMD unit tests on P300 board. This boards still have experimental fw so not available on CI but we ran to prevent any problems when Metal starts using it.
Description
Few fixes were needed to get UMD unit tests running properly. Asic location must for now be read from ETH cores, instead of the telemetry. Syseng folks are going to patch this in some of the upcoming fw releases. Second one was badly written test that is fixed now.
List of the changes
Testing
UMD unit tests pass on P300 locally.
API Changes
/