Implemented a new way of recording properties that works even if test is skipped #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
record_properties(key1=val1, key2=val2, ...)
which is meant to be used as a test decorator to capture any test properties["test_category", "jax_op_name", "shlo_op_name", "model_name", "run_mode"]
and implemented verification so that we don't accidentally make typos or other errors. These keys are expected by SQL in Superset.pytest.mark.skip
(orxfail
) decorator it will successfully record the data regardless, which wasn't possible with previous approach and some SQL hacks had to be done to circumvent thatrecord_property
andrecord_tt_xla_property
fixturesResult
We now have
instead of current
Note
Once this enters
main
, dashboard might be broken until I switch to new queries.