handle non existent previous operation, handle 404 operations (#58)

- prevent the call made for non existent previous operation - handle 404 for non existent operation
tenstorrent · Aug 12, 2024 · 07bb8b5 · 07bb8b5
2 parents 79c5d08 + 6e07994
commit 07bb8b5
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 17 deletions.
diff --git a/src/components/operation-details/OperationDetailsComponent.tsx b/src/components/operation-details/OperationDetailsComponent.tsx
@@ -42,7 +42,7 @@ const OperationDetailsComponent: React.FC<OperationDetailsProps> = ({ operationI
     const [zoomedInView, setZoomedInView] = useState(false);
 
     const {
-        operationDetails: { data: operationDetails, isLoading },
+        operationDetails: { data: operationDetails, isLoading, status },
     } = useOperationDetails(operationId);
 
     const { data: previousOperationDetails, isLoading: isPrevLoading } =
@@ -61,10 +61,13 @@ const OperationDetailsComponent: React.FC<OperationDetailsProps> = ({ operationI
 
     if (isLoading || isPrevLoading || !operationDetails || !previousOperationDetails) {
         return (
-            <OperationDetailsNavigation
-                operationId={operationId}
-                isLoading={isLoading}
-            />
+            <>
+                <OperationDetailsNavigation
+                    operationId={operationId}
+                    isLoading={isLoading}
+                />
+                {status === 'error' && <h3 className='not-found-message'>Operation {operationId} not found</h3>}
+            </>
         );
     }
 

diff --git a/src/hooks/useAPI.tsx b/src/hooks/useAPI.tsx
@@ -4,11 +4,35 @@
 
 import axios, { AxiosError } from 'axios';
 import { useQuery } from 'react-query';
-import { MicroOperation, OperationDescription, OperationDetailsData, ReportMetaData } from '../model/APIData';
-
-const fetchOperationDetails = async (id: number): Promise<OperationDetailsData> => {
-    const { data: operationDetails } = await axios.get<OperationDetailsData>(`/api/operations/${id}`);
-    return operationDetails;
+import {
+    MicroOperation,
+    OperationDescription,
+    OperationDetailsData,
+    ReportMetaData,
+    defaultOperationDetailsData,
+} from '../model/APIData';
+
+const fetchOperationDetails = async (id: number | null): Promise<OperationDetailsData> => {
+    if (id === null) {
+        return defaultOperationDetailsData;
+    }
+    try {
+        const { data: operationDetails } = await axios.get<OperationDetailsData>(`/api/operations/${id}`, {
+            maxRedirects: 1,
+        });
+        return operationDetails;
+    } catch (error: unknown) {
+        if (axios.isAxiosError(error)) {
+            if (error.response && error.response.status >= 400 && error.response.status < 500) {
+                // we may want to handle this differently
+                throw error;
+            }
+            if (error.response && error.response.status >= 500) {
+                throw error;
+            }
+        }
+    }
+    return defaultOperationDetailsData;
 };
 const fetchOperations = async (): Promise<OperationDescription[]> => {
     const [{ data: operationList }, { data: microOperations }] = await Promise.all([
@@ -46,18 +70,20 @@ export const useAllBuffers = () => {
     return useQuery<{ operation_id: number; buffers: [] }[], AxiosError>('get-operation-buffers', fetchAllBuffers);
 };
 
-export const useOperationDetails = (operationId: number) => {
+export const useOperationDetails = (operationId: number | null) => {
     const { data: operations } = useOperationsList();
     const operation = operations?.filter((_operation) => {
         return _operation.id === operationId;
     })[0];
-    const operationDetails = useQuery<OperationDetailsData>(['get-operation-detail', operationId], () =>
-        fetchOperationDetails(operationId),
+    const operationDetails = useQuery<OperationDetailsData>(
+        ['get-operation-detail', operationId],
+        () => fetchOperationDetails(operationId),
+        {
+            retry: 2,
+            retryDelay: (retryAttempt) => Math.min(retryAttempt * 100, 500),
+        },
     );
 
-
-    // TODO: consider useQueries or include operation data on BE
-
     return {
         operation,
         operationDetails,
@@ -72,7 +98,7 @@ export const usePreviousOperationDetails = (operationId: number) => {
         return operationList[index + 1]?.id === operationId;
     });
 
-    return useOperationDetails(operation ? operation.id : -1);
+    return useOperationDetails(operation ? operation.id : null);
 };
 
 export const usePreviousOperation = (operationId: number) => {

diff --git a/src/model/APIData.ts b/src/model/APIData.ts
@@ -35,6 +35,17 @@ export interface OperationDetailsData extends Operation {
     stack_trace: string;
 }
 
+// TODO: we may want to revisit the 'default' portion fo the variable name
+export const defaultOperationDetailsData: OperationDetailsData = {
+    id: 0,
+    name: '',
+    inputs: [],
+    outputs: [],
+    buffers: [],
+    l1_sizes: [],
+    stack_trace: '',
+};
+
 export interface Chunk {
     address: number;
     size: number;