Fix lint errors from Node/Package upgrade#1488
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates TypeScript tooling and adjusts several React components to satisfy lint/type-checking after the Node/package upgrade.
Changes:
- Upgrades TypeScript from 5.2.2 to 5.8.3 and switches
lint:tstopnpm exec. - Adds missing enum mappings and placeholder fields needed by stricter type checks.
- Refactors or suppresses React hook lint violations across UI components.
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package.json |
Updates TypeScript dependency and lint:ts command. |
pnpm-lock.yaml |
Refreshes lockfile entries for TypeScript 5.8.3. |
tsconfig.json |
Removes the project reference to tsconfig.node.json. |
src/hooks/useRemote.tsx |
Adds explicit persistence helper functions for remote connection state. |
src/components/report-selection/RemoteSyncConfigurator.tsx |
Uses new persistence helpers and defers some effect-driven state updates. |
src/functions/normalisePerformanceData.ts |
Adds isFirstHashOccurrence to placeholder perf rows. |
src/components/mlir/MlirJsonFileLoader.tsx |
Adds warning status icon/intent mappings. |
src/components/Collapsible.tsx |
Replaces prop-sync effect with guarded render-time state sync. |
src/components/RangeSlider.tsx |
Defers user-change flag resets via microtasks. |
src/components/operation-details/StackTrace.tsx |
Derives file path with useMemo and defers some source status resets. |
src/components/OperationList.tsx |
Adds React compiler/lint directives around virtualizer usage. |
src/components/TensorList.tsx |
Adds React compiler/lint directives around virtualizer usage. |
src/components/OperationGraphComponent.tsx |
Adds targeted React hook lint suppressions. |
src/components/npe/NPEViewComponent.tsx |
Adds targeted React hook lint suppressions. |
src/components/npe/NPETimelineComponent.tsx |
Adds targeted React hook lint suppression. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+182
to
+186
| setAppConfig(LOCAL_STORAGE_KEY_SELECTED, safeJsonStringify(connection ?? null)); | ||
| }; | ||
|
|
||
| const setPersistentSavedConnectionList = (connectionList: RemoteConnection[]) => { | ||
| setAppConfig(LOCAL_STORAGE_KEY_CONNECTIONS, safeJsonStringify(connectionList, '[]')); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Typescript (
pnpm lint:tsno longer worked) and updated various components to fix linting errors.Added ignore flags for NPE* and OperationGraphComponent problems.