Add track version id #116
Merged
Add track version id #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spl
suggested changes
Feb 7, 2022
There was a problem hiding this comment.
I think it would be better to use the term “data version” (e.g. dataVersion or getDataVersion) instead of just “version” throughout the code and comments. First, version is too ambiguous. Especially with software, I'd guess most people would first think it refers to the version of the library. Second, the use of “data version” helps to align the JavaScript client documentation with the HTTP API documentation.
Signed-off-by: NeelParihar <[email protected]>
Signed-off-by: NeelParihar <[email protected]>
Signed-off-by: NeelParihar <[email protected]>
Signed-off-by: NeelParihar <[email protected]>
spl
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #63