feat: Add support for private ca certs #155
Conversation
added example for private CA
mrobinson1022
changed the title
|
@bryantbiggs Let me know if you have any questions/changes for this PR |
.gitignore
Outdated
| @@ -27,3 +27,4 @@ override.tf.json | |||
| # Ignore CLI configuration files | |||
| .terraformrc | |||
| terraform.rc | |||
| .qodo | |||
| tags = local.tags | ||
| } | ||
|
|
||
| resource "aws_acmpca_certificate_authority" "root_ca" { |
There was a problem hiding this comment.
these are expensive - since this is a single attribute change, we can forgo the example in this case.
please remove the new example
| @@ -24,6 +24,8 @@ resource "aws_acm_certificate" "this" { | |||
| validation_method = var.validation_method | |||
| key_algorithm = var.key_algorithm | |||
|
|
|||
| certificate_authority_arn = var.private_authority_arn | |||
There was a problem hiding this comment.
looks like this is valid since v3.32 so no provider version bump required hashicorp/terraform-provider-aws#10213
|
@bryantbiggs I made the requested updates |
## [5.2.0](v5.1.1...v5.2.0) (2025-06-05) ### Features * Add support for private CA certificates ([#155](#155)) ([f5dffc6](f5dffc6))
|
This PR is included in version 5.2.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Added support for private CA acm certificates
Description
Added the following attribute and corresponding variable:
Motivation and Context
This allows the module to be used for private CA's to issue ACM certificates.
Breaking Changes
There should be no breaking change with this. The variable default is null so not having it declared should not result in any changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request