Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add ALB endpoint to example outputs #256

Merged
merged 7 commits into from
Mar 7, 2025

Conversation

setheliot
Copy link
Contributor

@setheliot setheliot commented Feb 11, 2025

Description

Add ALB endpoint to outputs for the ec2-autoscaling and complete examples

Motivation and Context

After running terraform apply, this makes it easier to find the ALB endpoint and test the deployment

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

This change is made only to an example itself.

  • I have executed pre-commit run -a on my pull request
$ pre-commit run -a                                                   

Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed

@setheliot setheliot changed the title Add ALB endpoint to outputs - this makes it easier to test for successful deployment feat: Add ALB endpoint to outputs - this makes it easier to test for successful deployment Feb 11, 2025
@setheliot
Copy link
Contributor Author

hi @antonbabenko -- may I get a review and hopefully a merge?

@bryantbiggs bryantbiggs changed the title feat: Add ALB endpoint to outputs - this makes it easier to test for successful deployment docs: Add ALB endpoint to example outputs Mar 7, 2025
@setheliot
Copy link
Contributor Author

Thank you @bryantbiggs - I have incorporated all of your feedback

@bryantbiggs bryantbiggs merged commit 00cc6b6 into terraform-aws-modules:master Mar 7, 2025
11 checks passed
Copy link

github-actions bot commented Apr 7, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants