Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ALB endpoint to outputs - this makes it easier to test for successful deployment #256

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

setheliot
Copy link

@setheliot setheliot commented Feb 11, 2025

Description

Add ALB endpoint to outputs for the ec2-autoscaling and complete examples

Motivation and Context

After running terraform apply, this makes it easier to find the ALB endpoint and test the deployment

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

This change is made only to an example itself.

  • I have executed pre-commit run -a on my pull request
$ pre-commit run -a                                                   

Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed

@setheliot setheliot changed the title Add ALB endpoint to outputs - this makes it easier to test for successful deployment feat: Add ALB endpoint to outputs - this makes it easier to test for successful deployment Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant