feat: Add support for multiple services inside service_connect_configuration #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment (terraform-aws-modules#284) replace timestamp() with plantimestamp()
|
thank you but this is already supported in #217 correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for multiple services inside service_connect_configuration
Motivation and Context
According to the Documentation of ECS, service_connect_configuration can configure multiple client-server services and hashicorp/aws provider supports for deploying it (as far as I know) after the major version 5.
Closes #289
Quote: https://registry.terraform.io/providers/hashicorp/aws/4.43.0/docs/resources/ecs_service#service_connect_configuration
However this module does not accept the list of Service Connect service objects and that is the issue this PR wants to fix.
Breaking Changes
Backward compatible
How Has This Been Tested?
Tested in a example and also in a private project (cannot share here)