-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cloudwatch_log_group_tags
parameter for log group tags
#472
feat: Add cloudwatch_log_group_tags
parameter for log group tags
#472
Conversation
variables.tf
Outdated
@@ -750,6 +750,12 @@ variable "cloudwatch_log_group_class" { | |||
default = null | |||
} | |||
|
|||
variable "cloudwatch_log_group_tags" { | |||
description = "A mapping of tags to assign to CloudWatch log groups" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "A mapping of tags to assign to CloudWatch log groups" | |
description = "Additional tags for the CloudWatch log group(s)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryantbiggs Fixed
Similar to `security_group_tags`, sometimes it is necessary to configure additional tags on CloudWatch log groups only.
acf0d77
to
9f622aa
Compare
cloudwatch_log_group_tags
parametercloudwatch_log_group_tags
parameter for log group tags
This PR is included in version 9.10.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add support for configuring tags for CloudWatch log groups only via
cloudwatch_log_group_tags
variable.Motivation and Context
Similar to
security_group_tags
, sometimes it is necessary to configure additional tags on CloudWatch log groups only. For example, in our organization we want to mark CloudWatch log groups with RDS logs as sensitive via a tag, but we don't want to apply this tag to all resources created by this module.Breaking Changes
No
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectsI ran
terraform plan
from "examples/postgresql" folder and checked thataws_cloudwatch_log_group
resources include a custom tag:pre-commit run -a
on my pull request