Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support non-AWS endpoint services #1152

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Dec 21, 2024

Description

PR delivers support for non-AWS endpoint services and resolves #1134.

Motivation and Context

#1134

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 21, 2025
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 21, 2025

@bryantbiggs I kindly ask for removing stale label and review :)

@github-actions github-actions bot removed the stale label Jan 22, 2025
@mmeidlinger
Copy link
Contributor

mmeidlinger commented Jan 29, 2025

This is already possible - no changes needed. The example #1134 in should be changed to this

endpoints = {
    my_company_artifactory = {
      service_name = "com.amazonaws.vpce.us-west-2.vpce-svc-07<redacted>b4"
      subnet_ids = try(module.vpc[0].private_subnets, [])
    }
  }

@sebastianczech
Copy link
Contributor Author

This is already possible - no changes needed. The example #1134 in should be changed to this

endpoints = {
    my_company_artifactory = {
      service_name = "com.amazonaws.vpce.us-west-2.vpce-svc-07<redacted>b4"
      subnet_ids = try(module.vpc[0].private_subnets, [])
    }
  }

I've checked your proposition and you are right - when we specify service_name instead of service_endpoint, then it works without any changes. In such case I'm going to close that issue. Thank you :)

@sebastianczech sebastianczech deleted the vpc-endpoint-non-aws-services branch February 12, 2025 18:16
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module vpc-endpoints to support non-AWS endpoint services
2 participants